linux-kernel - Re: [PATCH] mfd: sec-core: Remove unused s2mpu02-rtc and s2mpu02-clk children

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 30 Oct 2015 09:31:30 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
Cc:	Sangbeom Kim <sbkim73@...sung.com>,
	Chanwoo Choi <cw00.choi@...sung.com>,
	Javier Martinez Canillas <javier@....samsung.com>,
	linux-kernel@...r.kernel.org, linux-samsung-soc@...r.kernel.org
Subject: Re: [PATCH] mfd: sec-core: Remove unused s2mpu02-rtc and s2mpu02-clk
 children

On Fri, 30 Oct 2015, Krzysztof Kozlowski wrote:

> The commit 54e8827d5f0e ("mfd: sec-core: Add support for S2MPU02
> device") added new MFD child devices for S2MPU02: RTC and clock
> provider (the clock provider with new compatible). However support for
> these devices was not added to existing drivers (rtc-s5m, clk-s2mps11).
> New drivers were not submitted neither.
> 
> This means that the name of children devices is completely unused. The
> "samsung,s2mpu02-clk" compatible remains undocumented so it is unclear
> what is provided by that compatible.
> 
> Clean up this by removing unused child devices and undocumented
> compatible.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> 
> ---
> 
> I don't think that removing the "samsung,s2mpu02-clk" compatible would
> be considered as ABI break because:
> 1. Kernel did not document it as ABI.
> 2. Kernel did not provide any kind of feature for that compatible. It
>    was totally ignored.
> ---
>  drivers/mfd/sec-core.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c
> index 2626fc0b5b8c..989076d6cb83 100644
> --- a/drivers/mfd/sec-core.c
> +++ b/drivers/mfd/sec-core.c
> @@ -103,12 +103,9 @@ static const struct mfd_cell s2mpa01_devs[] = {
>  };
>  
>  static const struct mfd_cell s2mpu02_devs[] = {
> -	{ .name = "s2mpu02-pmic", },
> -	{ .name = "s2mpu02-rtc", },
>  	{
> -		.name = "s2mpu02-clk",
> -		.of_compatible = "samsung,s2mpu02-clk",
> -	}
> +		.name = "s2mpu02-pmic",
> +	},
>  };
>  
>  #ifdef CONFIG_OF

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/