linux-kernel - Re: [net-next PATCH] RDS: convert bind hash table to re-sizable hashtable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20151030.201536.285461609251750460.davem@davemloft.net>
Date:	Fri, 30 Oct 2015 20:15:36 +0900 (KST)
From:	David Miller <davem@...emloft.net>
To:	santosh.shilimkar@...cle.com
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	ssantosh@...nel.org
Subject: Re: [net-next PATCH] RDS: convert bind hash table to re-sizable
 hashtable

From: Santosh Shilimkar <santosh.shilimkar@...cle.com>
Date: Wed, 28 Oct 2015 15:51:12 -0700

> +					    &rs->rs_bound_node, ht_parms)) {
>  			*port = rs->rs_bound_port;
>  			ret = 0;
>  			rdsdebug("rs %p binding to %pI4:%d\n",
>  			  rs, &addr, (int)ntohs(*port));
>  			break;
>  		} else {
> -			rds_sock_put(rrs);
> +			rds_sock_put(rs);
> +			ret = -ENOMEM;
> +			break;
>  		}
> +
>  	} while (rover++ != last);
>  
>  	return ret;

This final insert of an empty line is both inappropriate and even
if it was it would not be related to this change.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/