linux-kernel - Re: [PATCH] snd-cs46xx: Fix Duplicate front for CS4294 and CS4298 codecs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5htwp8r3od.wl-tiwai@suse.de>
Date:	Fri, 30 Oct 2015 12:33:54 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	"Ondrej Zary" <linux@...nbow-software.org>
Cc:	<alsa-devel@...a-project.org>,
	"Kernel development list" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] snd-cs46xx: Fix Duplicate front for CS4294 and CS4298 codecs

On Thu, 29 Oct 2015 20:22:06 +0100,
Ondrej Zary wrote:
> 
> Currently, the Duplicate front control is enabled only for two specific
> revisions of CS4294.
> 
> Enable it for all CS4294 and CS4298 codecs instead.
> 
> This fixes rear output on my VC-4620N sound card
> (CS4620 + CS4298 rev.5).
> 
> Signed-off-by: Ondrej Zary <linux@...nbow-software.org>

Applied, thanks.


Takashi

> ---
>  sound/pci/cs46xx/cs46xx_lib.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/pci/cs46xx/cs46xx_lib.c b/sound/pci/cs46xx/cs46xx_lib.c
> index 2a9f4a3..e62c841 100644
> --- a/sound/pci/cs46xx/cs46xx_lib.c
> +++ b/sound/pci/cs46xx/cs46xx_lib.c
> @@ -2528,7 +2528,7 @@ int snd_cs46xx_mixer(struct snd_cs46xx *chip, int spdif_device)
>  #ifdef CONFIG_SND_CS46XX_NEW_DSP
>  	if (chip->nr_ac97_codecs == 1) {
>  		unsigned int id2 = chip->ac97[CS46XX_PRIMARY_CODEC_INDEX]->id & 0xffff;
> -		if (id2 == 0x592b || id2 == 0x592d) {
> +		if ((id2 & 0xfff0) == 0x5920) {	/* CS4294 and CS4298 */
>  			err = snd_ctl_add(card, snd_ctl_new1(&snd_cs46xx_front_dup_ctl, chip));
>  			if (err < 0)
>  				return err;
> -- 
> Ondrej Zary
> 
> .
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/