linux-kernel - Re: [PATCH 2/2] drivers:staging:gdm724x Fill all alignment should match open parentheses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 30 Oct 2015 12:48:09 +0100
From:	Bogicevic Sasa <brutallesale@...il.com>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] drivers:staging:gdm724x Fill all alignment should
 match open parentheses

On 10/30/2015, Sudip Mukherjee wrote:
>On Fri, Oct 30, 2015 at 09:59:19AM +0100, Bogicevic Sasa wrote:
>> On 10/30/2015, Sudip Mukherjee wrote:
>> >On Thu, Oct 29, 2015 at 09:15:01PM +0100, Bogicevic Sasa wrote:
>> >>This fixes all errors about alignment with open parentheses as well as
>> >>one spacing needed around "-" sign since the patch would not be valid if
>> >>I left it there
>> >
>> >1) That becomes two different type of change.
>> >2) This has already been done by
>> >a4785ef81023 ("staging: gdm724x: properly indent to match open paranthesis")
>> >I think you need to refresh your tree against current staging tree.
>> >
>> >3) your patch subject says 2/2, the next patch says 3/3 and the one
>> >after that is saying 4/4. There is something wrong in the way you are
>> >generating the patches. This 2/2 or 3/3 should not be here unless you
>> >are sending a series of patch.
>> >
>> >regards
>> >sudip
>> Ok 1) When I changed the alignment in one of the lines then
>> checkpatch.pl starts complaining about the spaces in the same line so
>> what do you do in that situation a) just submit anyway or b) fix it
>> I guess a according to your email
>
>It depends on how big that change will be. In this case it was ' '
>around '-', although if we go by the books, it should not be allowed,
>but one space related change can be overlooked. I wont have commented if
>points 2 and 3 were not there.
>
>> 2) I'll see what the hell did I do to not notice this
>> 3) I just pull, make a change, commit and do git format-patch
>> master..somebranch. Do I need to create separate branches for all
>> issues?
>
>No, separate branch should not be necessary. I have only one branch for
>staging related work. Did you use -n option while using git format-patch?
>
>regards
>sudip

Ah so that might be the catch I didnt use the -n option while creating
patches. Thanks for your help
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/