linux-kernel - Re: [PATCH v3 RESEND] scsi: report 'INQUIRY result too short' once per host

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <874mh8seez.fsf@vitty.brq.redhat.com>
Date:	Fri, 30 Oct 2015 13:56:36 +0100
From:	Vitaly Kuznetsov <vkuznets@...hat.com>
To:	Hannes Reinecke <hare@...e.de>
Cc:	James Bottomley <JBottomley@...n.com>, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	"K. Y. Srinivasan\" <kys@...rosoft.com>, Long Li <longli@...rosoft.com>, Dexuan Cui <decui@...rosoft.com>"@redhat.com
Subject: Re: [PATCH v3 RESEND] scsi: report 'INQUIRY result too short' once per host

Hannes Reinecke <hare@...e.de> writes:

> On 10/30/2015 12:40 PM, Vitaly Kuznetsov wrote:
>> Some host adapters (e.g. Hyper-V storvsc) are known for not respecting the
>> SPC-2/3/4 requirement for 'INQUIRY data (see table ...) shall contain at
>> least 36 bytes'. As a result we get tons on 'scsi 0:7:1:1: scsi scan:
>> INQUIRY result too short (5), using 36' messages on console. This can be
>> problematic for slow consoles. Introduce short_inquiry flag in struct
>> Scsi_Host to print the message once per host.
>> 
>> Signed-off-by: Vitaly Kuznetsov <vkuznets@...hat.com>
>> ---
>> Changes since v3 RESEND:
>> - Sorry, I screwed up James address when sending 'v3 RESEND'.
>> 
>> Changes since v3:
>> - no changes, this is just a RESEND.
>> 
>> Changes since v2:
>> - This is a successor of previously sent (and still not merged) "scsi:
>>   introduce short_inquiry flag for broken host adapters" patch. I'm not
>>   particularly sure which solution is better but I'm leaning towards this
>>   one as it doesn't require changes to adapter drivers.
>> ---
>>  drivers/scsi/scsi_scan.c | 9 ++++++---
>>  include/scsi/scsi_host.h | 3 +++
>>  2 files changed, 9 insertions(+), 3 deletions(-)
>> 
> Why not printk_once?
> Should achieve the same result, and we're saving yet another flag...
>

It seems it makes sense to print this warning per-host (as we can have
many hosts) and not just once. It's hard to come up with a reasonable
message for printk_once() -- "some of your SCSI devices are buggy"
sounds to vague. Here we say "this particular scsi controller is buggy".

-- 
  Vitaly
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/