linux-kernel - Re: [PATCH 1/3] recordmcount: fix endianness handling bug for nop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56338025.3060602@cogentembedded.com>
Date:	Fri, 30 Oct 2015 17:35:17 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Li Bin <huawei.libin@...wei.com>, will.deacon@....com,
	lkp@...el.com, catalin.marinas@....com, rostedt@...dmis.org,
	takahiro.akashi@...aro.org
Cc:	zhouchengming1@...wei.com, xiexiuqi@...wei.com,
	guohanjun@...wei.com, linux-kernel@...r.kernel.org,
	dingtianhong@...wei.com, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/3] recordmcount: fix endianness handling bug for
 nop_mcount

Hello.

On 10/30/2015 11:31 AM, Li Bin wrote:

> In nop_mcount, shdr->sh_offset and welp->r_offset should handle
> endianness properly, otherwise it will trigger Segmentation fault
> if the recordmcount main and file.o have different endianness.
>
> Cc: <stable@...r.kernel.org> # 3.0+
> Signed-off-by: Li Bin <huawei.libin@...wei.com>
> ---
>   scripts/recordmcount.h | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/recordmcount.h b/scripts/recordmcount.h
> index 49b582a..dda9dba 100644
> --- a/scripts/recordmcount.h
> +++ b/scripts/recordmcount.h
> @@ -376,8 +376,9 @@ static void nop_mcount(Elf_Shdr const *const relhdr,
>   			mcountsym = get_mcountsym(sym0, relp, str0);
>
>   		if (mcountsym == Elf_r_sym(relp) && !is_fake_mcount(relp)) {
> -			if (make_nop)
> -				ret = make_nop((void *)ehdr, shdr->sh_offset + relp->r_offset);
> +			if (make_nop) {
> +				ret = make_nop((void *)ehdr, _w(shdr->sh_offset) + _w(relp->r_offset));
> +			}

    {} not needed here.

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/