linux-kernel - Re: [PATCH] sysfs: add devm_sysfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151030144037.GC27072@kroah.com>
Date:	Fri, 30 Oct 2015 07:40:37 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	htejun@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sysfs: add devm_sysfs_create_group() and friends

On Fri, Oct 30, 2015 at 04:47:06AM -0700, Dmitry Torokhov wrote:
> Many drivers create additional driver-specific device attributes when
> binding to the device and providing managed version of sysfs_create_group()
> will simplify unbinding and error handling in probe path for such drivers.

But they really shouldn't, because if they do this, they have raced
userspace and tools don't know that the files are present.

I don't want to encourage drivers to do this at all, so I don't want to
make it easier for them to do things incorrectly.

Yes, I know that input does this for its devices, but I still think it
is wrong and should be changed.  Let's not let this problem spread to
other subsystems please.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/