linux-kernel - Re: [PATCH v5 5/5] gpio: tps65912: Add GPIO driver for the TPS65912 PMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 30 Oct 2015 17:10:45 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	"Andrew F. Davis" <afd@...com>, Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Alexandre Courbot <gnurou@...il.com>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 5/5] gpio: tps65912: Add GPIO driver for the TPS65912
 PMIC

On Fri, 30 Oct 2015, Linus Walleij wrote:

> On Fri, Oct 30, 2015 at 12:38 AM, Andrew F. Davis <afd@...com> wrote:
> 
> > This patch adds support for the TPS65912 PMIC GPIOs.
> >
> > TPS65912 has five configurable GPIOs that can be used for several
> > purposes.
> >
> > Signed-off-by: Andrew F. Davis <afd@...com>
> 
> This looks like a fine driver, can't really see anything wrong with it so:
> Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
> 
> > +#define to_tps65912_gpio(gc) container_of(gc, struct tps65912_gpio, gpio_chip)
> 
> I would rewrite that to static inline however.
> 
> Lee can take this into the MFD tree with my review-tag if he wants.

Please fix this, then resubmit the set with Acks/Reviewed-by's applied.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/