linux-kernel - Re: [PATCH 09/13] drm/irq: Make pipe unsigned and name consistent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAKb7Uviu831ivU7nLA65qMaWe+i_2wnYQQkEO+K3YM9exBEgTQ@mail.gmail.com>
Date:	Fri, 30 Oct 2015 14:38:51 -0400
From:	Ilia Mirkin <imirkin@...m.mit.edu>
To:	Daniel Vetter <daniel@...ll.ch>
Cc:	Thierry Reding <thierry.reding@...il.com>,
	Daniel Vetter <daniel.vetter@...ll.ch>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 09/13] drm/irq: Make pipe unsigned and name consistent

On Wed, Aug 12, 2015 at 11:32 AM, Daniel Vetter <daniel@...ll.ch> wrote:
> On Wed, Aug 12, 2015 at 05:00:31PM +0200, Thierry Reding wrote:
>> From: Thierry Reding <treding@...dia.com>
>>
>> Name all references to the pipe number (CRTC index) consistently to make
>> it easier to distinguish which is a pipe number and which is a pointer
>> to struct drm_crtc.
>>
>> While at it also make all references to the pipe number unsigned because
>> there is no longer any reason why it should ever be negative.
>>
>> Signed-off-by: Thierry Reding <treding@...dia.com>
>
> There's 2 "int crtc" and one "int pipe" (without the unsigned) left after
> this patch. Can you please do a follow-up? Applied this meanwhile.

4.3 is about to get released, and the regression for nouveau that this
change introduces (https://bugzilla.kernel.org/show_bug.cgi?id=106431)
is still not fixed.

Can you remove the warn for now or explicitly allow ~0U? Don't want to
start spewing warns for everyone with a pre-tesla nvidia gpu...

Thanks,

  -ilia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/