linux-kernel - Re: [PATCH v4 3/3] USB: serial: cp210x: Workaround cp2108 GET_LINE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151031121612.GC2636@localhost>
Date:	Sat, 31 Oct 2015 13:16:12 +0100
From:	Johan Hovold <johan@...nel.org>
To:	Konstantin Shkolnyy <konstantin.shkolnyy@...il.com>
Cc:	Johan Hovold <johan@...nel.org>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 3/3] USB: serial: cp210x: Workaround cp2108
 GET_LINE_CTL bug

[ Please avoid top-posting. ]

On Thu, Oct 29, 2015 at 08:39:04AM -0500, Konstantin Shkolnyy wrote:
> I tested it on cp2102, cp2105 and cp2108.
> I'm a little worried about that extra PURGE command, so I did several
> manual tests on each with a standard PC serial port on the other end
> of the cable.
> - run several open/write/close iteration (the test that used to break
> cp2108), observe data on the other end;
> - open minicom and see that cp210x can still receive data from the other end.

Sounds good.

If this turns out to cause any problems, we can always enable this based
on chip type, right? I saw something about a vendor request for that in
your (silabs') vendor driver.

> BTW, can you suggest (preferably automated) serial port test s/w?

No, sorry. I have a bunch of test code that I intend to organise and
clean up at some point, but I never seem to find the time to actually do
it.

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/