lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20151031014110.GA1991@localhost> Date: Sat, 31 Oct 2015 01:41:10 +0000 From: Olof Johansson <olof@...om.net> To: Linus Walleij <linus.walleij@...aro.org> Cc: Masahiro Yamada <yamada.masahiro@...ionext.com>, "arm@...nel.org" <arm@...nel.org>, "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 1/2] pinctrl: uniphier: enable UniPhier SoCs pinctrl drivers by default On Thu, Oct 29, 2015 at 02:33:34PM +0100, Linus Walleij wrote: > On Tue, Oct 27, 2015 at 3:28 AM, Masahiro Yamada > <yamada.masahiro@...ionext.com> wrote: > > > Add "default y" to the Kconfig rather than adding entries into > > arch/arm/configs/multi_v7_defconfig. > > > > Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com> > > (...) > > config PINCTRL_UNIPHIER_PH1_LD4 > > tristate "UniPhier PH1-LD4 SoC pinctrl driver" > > + default y > > select PINCTRL_UNIPHIER_CORE > > Why is it not default y if <PH1_LD4_SOC_THING>? > > So it is only turned on if the corresponding SoC is selected? > > Or don't you have symbols like that? > > ARM SoC folks: can you ACK this patch indicating that this is the way > you wanna handle this? Most other will have a "default MACH_<foo>", but Uniphier lacks those Kconfig symbols. Or even a def_bool for that platform such that it's not an option if the platform is enabled. It makes no sense to enable a platform but not the pinctrl on it, so that's a good way to do it. I would honestly rather have those in the mach makefile, and make the drivers select the right thing by default, than having to know exactly which drivers to enable for a specific SoC. -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists