lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <56349293.7030107@kernel.org> Date: Sat, 31 Oct 2015 10:06:11 +0000 From: Jonathan Cameron <jic23@...nel.org> To: Bjorn Andersson <bjorn.andersson@...ymobile.com>, Hartmut Knaack <knaack.h@....de>, Lars-Peter Clausen <lars@...afoo.de>, Johan Hovold <jhovold@...il.com>, Peter Meerwald <pmeerw@...erw.net> Cc: linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH v3 2/3] iio: light: lm3533-als: Print error message on invalid resistance On 30/10/15 23:50, Bjorn Andersson wrote: > Print an error message to indicate that invalid configuration data was > provided in the platform_data, rather than just aborting initialization. > > Signed-off-by: Bjorn Andersson <bjorn.andersson@...ymobile.com> Seems sensible to me. Applied to the togreg branch of iio.git - initially pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > --- > > This patch can be picked independently of the other 2, but included in the > series for "completeness". > > No changes since v1 in this patch. > > drivers/iio/light/lm3533-als.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/iio/light/lm3533-als.c b/drivers/iio/light/lm3533-als.c > index 076bc46fad03..e56937c40a18 100644 > --- a/drivers/iio/light/lm3533-als.c > +++ b/drivers/iio/light/lm3533-als.c > @@ -743,8 +743,10 @@ static int lm3533_als_set_resistor(struct lm3533_als *als, u8 val) > { > int ret; > > - if (val < LM3533_ALS_RESISTOR_MIN || val > LM3533_ALS_RESISTOR_MAX) > + if (val < LM3533_ALS_RESISTOR_MIN || val > LM3533_ALS_RESISTOR_MAX) { > + dev_err(&als->pdev->dev, "invalid resistor value\n"); > return -EINVAL; > + }; > > ret = lm3533_write(als->lm3533, LM3533_REG_ALS_RESISTOR_SELECT, val); > if (ret) { > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists