linux-kernel - Re: [PATCH] comedi: drivers: Fix - BIT macro used coding style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151101181059.GA14252@kroah.com>
Date:	Sun, 1 Nov 2015 10:10:59 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Andy Shevchenko <andy.shevchenko@...il.com>
Cc:	Ranjith <ranjithece24@...il.com>, devel@...verdev.osuosl.org,
	Ian Abbott <abbotti@....co.uk>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] comedi: drivers: Fix - BIT macro used coding style issue

On Sun, Nov 01, 2015 at 12:20:59PM +0200, Andy Shevchenko wrote:
> On Sun, Nov 1, 2015 at 11:59 AM, Ranjith <ranjithece24@...il.com> wrote:
> > BIT macro is used for defining bit location instead of shifting
> > operator -  coding style issue
> 
> >  #define APCI1032_CTRL_INT_OR           (0 << 1)
> 
> > +#define APCI1032_CTRL_INT_AND          BIT(1)
> 
> And now you have two styles at the same time. I wouldn't change the
> current definitions.

Yes you should, just use BIT(0) for this one.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/