[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20151101.165151.1119828043753664843.davem@davemloft.net>
Date: Sun, 01 Nov 2015 16:51:51 -0500 (EST)
From: David Miller <davem@...emloft.net>
To: p.fedin@...sung.com
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
steve.glendinning@...well.net
Subject: Re: [PATCH] net: smsc911x: Reset PHY during initialization
From: Pavel Fedin <p.fedin@...sung.com>
Date: Fri, 30 Oct 2015 10:06:19 +0300
> On certain hardware after software reboot the chip may get stuck and fail
> to reinitialize during reset. This can be fixed by ensuring that PHY is
> reset too.
>
> Old PHY resetting method required operational MDIO interface, therefore
> the chip should have been already set up. In order to be able to function
> during probe, it is changed to use PMT_CTRL register.
>
> The problem could be observed on SMDK5410 board.
>
> Signed-off-by: Pavel Fedin <p.fedin@...sung.com>
I'm pretty sure this is going to break the PHY loopback test.
This is such a tricky and fragile area to get right, therefore I
want you to specifically guard any change in how PHY reset is
done with tests against the specific chips that have the problem.
Furthermore, I want you to test whether this has any negative
effects on the PHY loopback test.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists