linux-kernel - Re: [PATCH 2/2] i2c: add driver for Sigma Designs SMP8642 I2C master

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yw1x4mh5c190.fsf@unicorn.mansr.com>
Date:	Sun, 01 Nov 2015 13:12:11 +0000
From:	Måns Rullgård <mans@...sr.com>
To:	Wolfram Sang <wsa@...-dreams.de>
Cc:	linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org
Subject: Re: [PATCH 2/2] i2c: add driver for Sigma Designs SMP8642 I2C master

Wolfram Sang <wsa@...-dreams.de> writes:

> On Sat, Oct 31, 2015 at 05:35:57PM +0000, Mans Rullgard wrote:
>> This adds a driver for the Sigma Designs SMP8642 built-in I2C master
>> controller.  The hardware is very similar to the I2C controller in the
>> Ralink RT3050 chip with the addition of interrupt generation and an
>> inverted busy/idle status bit.  There are typically two controllers with
>> a shared IRQ.
>> 
>> Signed-off-by: Mans Rullgard <mans@...sr.com>
>
> Thanks for the driver. Same answer as here, though:
>
> http://www.spinics.net/lists/linux-i2c/msg17001.html
>
>> +#define TANGOX_I2C_CONFIG		0x00
>> +#define TANGOX_I2C_CLKDIV		0x04
>> +#define TANGOX_I2C_DEVADDR		0x08
>> +#define TANGOX_I2C_ADDR			0x0c
>> +#define TANGOX_I2C_DATAOUT		0x10
>> +#define TANGOX_I2C_DATAIN		0x14
>> +#define TANGOX_I2C_STATUS		0x18
>> +#define TANGOX_I2C_STARTXFER		0x1c
>> +#define TANGOX_I2C_BYTECNT		0x20
>> +#define TANGOX_I2C_INT_EN		0x24
>> +#define TANGOX_I2C_INT_STAT		0x28
>
> The register set looks like the one from i2c-xlr.c, only that they are
> 32 bit apart instead of 8. Can you check if you can reuse that driver?

It does look very similar indeed.  I thought I'd checked for an existing
driver, but apparently I missed that one.  I'll modify the xlr driver to
handle this hardware as well instead.

-- 
Måns Rullgård
mans@...sr.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/