linux-kernel - Re: [PATCH] ALSA: firewire-lib: fix compare_const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1511020819390.2096@localhost6.localdomain6>
Date:	Mon, 2 Nov 2015 08:20:26 +0100 (CET)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	Takashi Sakamoto <o-takashi@...amocchi.jp>
cc:	Julia Lawall <julia.lawall@...6.fr>, kbuild-all@...org,
	Takashi Iwai <tiwai@...e.de>,
	Clemens Ladisch <clemens@...isch.de>,
	Jaroslav Kysela <perex@...ex.cz>, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: firewire-lib: fix compare_const_fl.cocci
 warnings

On Mon, 2 Nov 2015, Takashi Sakamoto wrote:

> Hi,
> 
> On Nov 02 2015 15:55, Julia Lawall wrote:
> > Move constant to the right of binary operators.
> > 
> > Generated by: scripts/coccinelle/misc/compare_const_fl.cocci
> > 
> > CC: Takashi Sakamoto <o-takashi@...amocchi.jp>
> > Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
> > Signed-off-by: Julia Lawall <julia.lawall@...6.fr>
> > ---
> > 
> > Depends on personal taste, but the modified version does look a little
> > nicer to me, since one can better see the relationship between the fdf
> > and sfc fields.
> > 
> >   amdtp-am824.c |    2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > --- a/sound/firewire/amdtp-am824.c
> > +++ b/sound/firewire/amdtp-am824.c
> > @@ -36,7 +36,7 @@ int amdtp_am824_set_parameters(struct am
> >   	if (err < 0)
> >   		return err;
> > 
> > -	s->fdf = AMDTP_FDF_AM824 | s->sfc;
> > +	s->fdf = s->sfc | AMDTP_FDF_AM824;
> > 
> >   	/*
> >   	 * In IEC 61883-6, one data block represents one event. In ALSA, one
> 
> Could I request explainations about the advantage of this modification? I
> cannot imagine good reasons for this subtle changes...

I put the reason under the --- (better see the relationship between fdf 
and sfc).  But if you think the code makes more sense as it is, just 
ignore the patch.

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/