linux-kernel - Re: [RESEND PATCH v3] scsi: stex: Remove use of struct timeval

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <563715A4.5030400@suse.de>
Date:	Mon, 2 Nov 2015 08:49:56 +0100
From:	Hannes Reinecke <hare@...e.de>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Tina Ruchandani <ruchandani.tina@...il.com>,
	linux-scsi@...r.kernel.org,
	"James E.J. Bottomley" <JBottomley@...n.com>,
	y2038@...ts.linaro.org, linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH v3] scsi: stex: Remove use of struct timeval

On 10/30/2015 01:45 PM, Arnd Bergmann wrote:
> On Friday 30 October 2015 12:58:33 Hannes Reinecke wrote:
>>> @@ -1076,7 +1069,7 @@ static int stex_ss_handshake(struct st_hba *hba)
>>>       h->req_cnt = cpu_to_le16(hba->rq_count+1);
>>>       h->status_sz = cpu_to_le16(sizeof(struct status_msg));
>>>       h->status_cnt = cpu_to_le16(hba->sts_count+1);
>>> -     stex_gettime(&h->hosttime);
>>> +     h->hosttime = cpu_to_le64(ktime_get_real_seconds());
>>>       h->partner_type = HMU_PARTNER_TYPE;
>>>       h->extra_offset = h->extra_size = 0;
>>>       scratch_size = (hba->sts_count+1)*sizeof(u32);
>>>
>> Just remove 'hosttime' altogether. It serves no purpose whatsoever.
>>
>>
> 
> Are you sure? It is defined in a struct that is shared with the HBA
> as part of hba->dma_mem, so unless you have access to the firmware,
> it's hard to guess what it might be used for inside of the firmware.
> 
Ah, you're right. Okay, so we'll need to convert it.

Cheers,

Hannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/