[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAJKOXPf+twUu4_fxjQ1Xp24L-YzNj6=mZ+dOxu72FWJcrYk3Rw@mail.gmail.com>
Date: Mon, 2 Nov 2015 21:27:57 +0900
From: Krzysztof Kozlowski <k.kozlowski@...sung.com>
To: Alim Akhtar <alim.akhtar@...sung.com>
Cc: Krzysztof Kozlowski <k.kozlowski@...sung.com>,
linux-samsung-soc@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
kgene@...nel.org
Subject: Re: [PATCH 2/2] arm64: dts: exynos7: Enable HS200 mode operation
2015-11-02 21:08 GMT+09:00 Alim Akhtar <alim.akhtar@...sung.com>:
> Hi Krzysztof,
>
>
> On 11/02/2015 05:28 PM, Krzysztof Kozlowski wrote:
>>
>> Subject - name of the board at the end (not the name of the SoC):
>> arm64: dts: Enable HS200 mode operation on exynos7-espresso
>>
>> 2015-11-02 19:04 GMT+09:00 Alim Akhtar <alim.akhtar@...sung.com>:
>>>
>>> This patch enables HS200 mode operation on exynos7 based
>>> espresso board.
>>> This also remove _broken-cd_ property as per mmc binding documentation
>>
>>
>> s/remove/removes/
>>
>>> which say one of the properties between broken-cd and non-removable
>>
>>
>> s/say/says/
>>
>>> should be used. And we already use _non-removable_ as emmc mounted
>>> on board which is a non-removable device.
>>>
>>> Signed-off-by: Alim Akhtar <alim.akhtar@...sung.com>
>>> ---
>>> arch/arm64/boot/dts/exynos/exynos7-espresso.dts | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
>>> b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
>>> index 8ce04a0ec928..7f19b99fc85b 100644
>>> --- a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
>>> +++ b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
>>> @@ -405,8 +405,8 @@
>>> &mmc_0 {
>>> status = "okay";
>>> num-slots = <1>;
>>> - broken-cd;
>>> cap-mmc-highspeed;
>>> + mmc-hs200-1_8v;
>>
>>
>> The "mmc-ddr-1_8v" should also be supported but I guess you did not
>> add it on purpose?
>>
> Well, I have not tested it, that why didn't added. Will check if this works
> then will add.
> Thanks for your comments.
Right, it would require testing... Just came to my mind. Anyway this
is up to you.
Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists