linux-kernel - Re: [PATCH 2/2] comedi: drivers: Fix - BIT macro used coding style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <563774D0.8050908@mev.co.uk>
Date:	Mon, 02 Nov 2015 14:36:00 +0000
From:	Ian Abbott <abbotti@....co.uk>
To:	ranjithece24@...il.com, gregkh@...uxfoundation.org
CC:	hsweeten@...ionengravers.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] comedi: drivers: Fix - BIT macro used coding style
 issue

On 02/11/15 14:25, ranjithece24@...il.com wrote:
> From: Ranjith <ranjithece24@...il.com>
>
> BIT macro is used for defining BIT location instead of shifting
> operator - coding style issue
>
> Signed-off-by: Ranjith <ranjithece24@...il.com>
> ---
>   drivers/staging/comedi/drivers/addi_apci_1032.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/drivers/addi_apci_1032.c b/drivers/staging/comedi/drivers/addi_apci_1032.c
> index fd5ce21..168602b 100644
> --- a/drivers/staging/comedi/drivers/addi_apci_1032.c
> +++ b/drivers/staging/comedi/drivers/addi_apci_1032.c
> @@ -84,7 +84,7 @@
>   #define APCI1032_MODE2_REG		0x08
>   #define APCI1032_STATUS_REG		0x0c
>   #define APCI1032_CTRL_REG		0x10
> -#define APCI1032_CTRL_INT_OR		(0 << 1)
> +#define APCI1032_CTRL_INT_OR		BIT(0)
>   #define APCI1032_CTRL_INT_AND		BIT(1)
>   #define APCI1032_CTRL_INT_ENA		BIT(2)

No, that's wrong.  (0 << 1) is 0, but BIT(0) is 1.

Hartley already fixed the coding style issue.  It's in linux-next.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/