linux-kernel - Re: [PATCH v7 2/7] dmaengine: mxs: APBH DMA supports deep sleep mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151102162906.1e3c29da@free-electrons.com>
Date:	Mon, 2 Nov 2015 16:29:06 +0100
From:	Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
To:	Vinod Koul <vinod.koul@...el.com>
Cc:	Han Xu <b45815@...escale.com>, fabio.estevam@...escale.com,
	boris.brezillon@...e-electrons.com, linux-kernel@...r.kernel.org,
	dmaengine@...r.kernel.org, linux-mtd@...ts.infradead.org,
	hofrat@...dl.org, shijie.huang@....com, dan.j.williams@...el.com,
	computersforpeace@...il.com, dwmw2@...radead.org
Subject: Re: [PATCH v7 2/7] dmaengine: mxs: APBH DMA supports deep sleep
 mode

Vinod,

On Sat, 31 Oct 2015 07:12:44 +0530, Vinod Koul wrote:
> On Tue, Oct 27, 2015 at 05:05:35PM -0500, Han Xu wrote:
> >  
> > -static int __init mxs_dma_init(struct mxs_dma_engine *mxs_dma)
> > +static int mxs_dma_init(struct mxs_dma_engine *mxs_dma)
> 
> This change seems unrelated to patch description, can you explain why?

It seems related: mxs_dma_init() is now no longer called at
initialization time, but also when resuming, as visible...

> 
> > +#ifdef CONFIG_PM_SLEEP
> > +static int mxs_dma_pm_resume(struct device *dev)
> > +{
> > +	struct mxs_dma_engine *mxs_dma = dev_get_drvdata(dev);
> > +	int ret;
> > +
> > +	ret = mxs_dma_init(mxs_dma);

... here.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/