linux-kernel - Re: [PATCH 2/2] efirtc: add efi_enabled check in efi_rtc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6366386.xsGhxxeFtE@wuerfel>
Date:	Mon, 02 Nov 2015 16:37:51 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Geliang Tang <geliangtang@....com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org, Tony Luck <tony.luck@...el.com>,
	Fenghua Yu <fenghua.yu@...el.com>
Subject: Re: [PATCH 2/2] efirtc: add efi_enabled check in efi_rtc_init

On Monday 02 November 2015 22:49:01 Geliang Tang wrote:
> diff --git a/drivers/char/efirtc.c b/drivers/char/efirtc.c
> index 5323d8c..80058bd 100644
> --- a/drivers/char/efirtc.c
> +++ b/drivers/char/efirtc.c
> @@ -378,6 +378,9 @@ efi_rtc_init(void)
>         int ret;
>         struct proc_dir_entry *dir;
>  
> +       if (!efi_enabled(EFI_RUNTIME_SERVICES))
> +               return 0;
> 

Are there any Itanium machines that don't enable runtime services?
This seems a little redundant otherwise.

Are you trying to run the ancient driver on non-Itanium systems?

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/