linux-kernel - Re: make xconfig no longer works in Fedora

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 2 Nov 2015 16:28:29 +0000
From:	Alexey Brodkin <Alexey.Brodkin@...opsys.com>
To:	"thiago.macieira@...el.com" <thiago.macieira@...el.com>
CC:	"mmarek@...e.com" <mmarek@...e.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: make xconfig no longer works in Fedora

Hi Thiago,

On Mon, 2015-11-02 at 11:01 -0500, Thiago Macieira wrote:
> On Monday 02 November 2015 16:50:33 Michal Marek wrote:
> > On Mon, Nov 02, 2015 at 08:46:55AM -0500, Thiago Macieira wrote:
> > > On Monday 02 November 2015 11:36:43 Michal Marek wrote:
> > > > On 2015-11-02 04:20, Thiago Macieira wrote:
> > > > > -	qtver=`qmake -query QT_VERSION` || { \
> > > > > +	qtver=`qmake -query QT_VERSION` || \
> > > > > +	qtver=`qmake-qt5 -query QT_VERSION` || \
> > > > > +	qtver=`qmake-qt4 -query QT_VERSION` || { \
> > > > 
> > > > The qtlibdir= etc assignments below still use qmake directly, plus this
> > > > will print an error if the command is not called "qmake." As Alexey
> > > > says, we do not need qmake, we need moc and the cflags / ldflags. Since
> > > > pkg-config worked for us previously, I suggest to use pkg-config again
> > > > and just check which of QtGui or Qt5Widgets is available.
> > > 
> > > Here's an attempt using pkg-config.
> > 
> > Works for me on openSUSE, it just started to prefer Qt5 now. But it
> > correctly builds against Qt4 if Qt5 is not available.
> 
> That's a consequence of using pkg-config. Now you can no longer choose your 
> preferred Qt version by setting QT_SELECT, like the qmake solution would have 
> allowed, as recommended by the Qt Project. At least, the qtchooser shell 
> function extension does set PKG_CONFIG_PATH, so if you  install a different 
> version elsewhere, that version should be picked up.
> 
> It would have been the same with CMake too, btw.
> 
> Alexey, did this solve the problem for you?

Yep, thanks a lot.
"make xconfig" now works for me!

-Alexey