linux-kernel - Re: make xconfig no longer works in Fedora

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1540852.ryHORPH4E7@tjmaciei-mobl4>
Date:	Sun, 01 Nov 2015 21:20:43 -0600
From:	Thiago Macieira <thiago.macieira@...el.com>
To:	Alexey Brodkin <Alexey.Brodkin@...opsys.com>
Cc:	"mmarek@...e.com" <mmarek@...e.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: make xconfig no longer works in Fedora

On Saturday 31 October 2015 12:39:21 Alexey Brodkin wrote:
> Hi Thiago,
> 
> I noticed that with your patch "Update the buildsystem for KConfig finding
> Qt"
> I cannot use "make xconfig" in Fedora 22 any longer.

Hello Alexey

> The reason why xconfig target fails is in Fedora (at least its recent
> versions)
> there's no "qmake". Instead there're "qmake-qt4" and/or
> "qmake-qt5" depending on which Qt packages are installed.

Hmm... you're right. There's no check for a program with a different name in 
the new Makefile. I apologise, I never tested that case.

Fedora is knowingly deviating from Qt Project recommendations. I will fix 
this, but please file a bug report against their Qt packages so there's some 
pressure to adopt a standard solution that everyone else already does.

> But IMHO it would be really nice if we don't break things that used to
> work.

Right. Can you try the attached patch to see if it solves the problem for you?

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center

View attachment "0001-Attempt-to-find-qmake-qt5-and-qmake-qt4-if-no-qmake-.patch" of type "text/x-patch" (1281 bytes)