linux-kernel - Re: [PATCH v4 1/6] arm64: ftrace: adjust callsite addresses examined by stack tracer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151102184330.GK2684@leverpostej>
Date:	Mon, 2 Nov 2015 18:43:31 +0000
From:	Mark Rutland <mark.rutland@....com>
To:	Will Deacon <will.deacon@....com>
Cc:	Steven Rostedt <rostedt@...dmis.org>, jungseoklee85@...il.com,
	catalin.marinas@....com, linux-kernel@...r.kernel.org,
	AKASHI Takahiro <takahiro.akashi@...aro.org>,
	broonie@...nel.org, david.griego@...aro.org, olof@...om.net,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v4 1/6] arm64: ftrace: adjust callsite addresses examined
 by stack tracer

On Mon, Nov 02, 2015 at 06:41:24PM +0000, Will Deacon wrote:
> On Mon, Nov 02, 2015 at 06:29:28PM +0000, Mark Rutland wrote:
> > On Mon, Nov 02, 2015 at 01:20:43PM -0500, Steven Rostedt wrote:
> > > On Fri, 30 Oct 2015 11:16:19 +0000
> > > Will Deacon <will.deacon@....com> wrote:
> > > 
> > > > On Fri, Oct 30, 2015 at 02:25:36PM +0900, AKASHI Takahiro wrote:
> > > > > On arm64, no PC values returned by save_stack_trace() will match to LR
> > > > > values saved in stack frames on a stack after the following commit:
> > > > >     commit e306dfd06fcb ("ARM64: unwind: Fix PC calculation")
> > > > > As a result, the output from stack tracer will be messed up.
> > > > 
> > > > FWIW, we've decided to revert that patch for the moment. We're the only
> > > > architecture making that kind of adjustment, so we should fix that before
> > > > building on top of it.
> > > > 
> > > >
> > > 
> > > What is the status of this patch set. I'm currently pulling in last
> > > minute patches for 4.3 and should the ftrace patch in this series be
> > > applied? (I still need to review it too).
> > 
> > The revert Will mentioned is in v4.3 (see commit 9702970c7bd3e2d6), so
> > this series needs a respin to account for that.
> 
> Right, but we're talking about the core ftrace change in patch 4, which
> is (afaict) independent of the commit you mention above.

Ah; I don't know on that front, sorry for the noise.

Mark.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/