linux-kernel - Re: [PATCH -next] serial: etraxfs-uart: Fix crash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5637D1F5.2090608@flawful.org>
Date:	Mon, 2 Nov 2015 22:13:25 +0100
From:	Niklas Cassel <nks@...wful.org>
To:	Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
	Guenter Roeck <linux@...ck-us.net>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jslaby@...e.com>, linux-serial@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] serial: etraxfs-uart: Fix crash



On 11/02/2015 08:37 AM, Uwe Kleine-König wrote:
>> The function call in the etraxfs-uart driver was not renamed,
>> possibly due to interference with commit 7b9c5162c182 ("serial:
>> etraxfs-uart: use mctrl_gpio helpers for handling modem signals").
> Yes. BTW, 7b9c5162c182 looks broken, too, because the interrupt handling
> is missing.

The only drivers including serial_mctrl_gpio.h is atmel_serial.c,
clps711x.c, mxs-auart.c and etraxfs-uart.c

etraxfs commit
7b9c5162c182 ("serial: etraxfs-uart: use mctrl_gpio helpers for handling modem signals")
is heavily influenced by
62b0a1b3e759 ("serial: clps711x: Use mctrl_gpio helpers for handling modem signals")

a driver which also appears to lack mctrl irq setup/handling.


Uwe, are you going to convert all serial drivers that includes serial_mctrl_gpio.h to
use the new mctrl_gpio_init? (which also sets up irqs)

Since mctrl gpios are optional in the device tree, I guess mctrl_gpio_init handles if
they are missing. So even if etraxfs-uart.c currently lacks mctrl irq setup/handling,
if we migrate it to use the new mctrl_gpio_init, we will get this automatically?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/