linux-kernel - Re: MMC/regulator boot hang in -next

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151103053555.GM20228@sirena.org.uk>
Date:	Tue, 3 Nov 2015 05:35:55 +0000
From:	Mark Brown <broonie@...nel.org>
To:	John Stultz <john.stultz@...aro.org>
Cc:	Bjorn Andersson <bjorn.andersson@...ymobile.com>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Ulf Hansson <ulf.hansson@...aro.org>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: MMC/regulator boot hang in -next

On Mon, Nov 02, 2015 at 03:04:29PM -0800, John Stultz wrote:
> On Mon, Nov 2, 2015 at 2:58 PM, Mark Brown <broonie@...nel.org> wrote:

> > No, the internal get voltage call shouldn't be locking in the first
> > place (and indeed it doesn't do so AFAICT?).

>         } else if (rdev->supply) {
>                 ret = regulator_get_voltage(rdev->supply);    <-----
>         } else {

> Where _regulator_get_voltage() is called from
> regulator_set_voltage_unlocked(), called from regulator_set_voltage().
> 

Well, that's the issue then - get_voltage() needs to be locking the
supplies like set_voltage() does.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)