linux-kernel - Re: [PATCH RESEND 14/16] hwmon: add TI LMU hardware fault monitoring driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56385BCE.5060300@ti.com>
Date:	Tue, 3 Nov 2015 16:01:34 +0900
From:	"Kim, Milo" <milo.kim@...com>
To:	Guenter Roeck <linux@...ck-us.net>
CC:	<devicetree@...r.kernel.org>, <lee.jones@...aro.org>,
	<linux-kernel@...r.kernel.org>, Jean Delvare <jdelvare@...e.com>,
	<lm-sensors@...sensors.org>
Subject: Re: [PATCH RESEND 14/16] hwmon: add TI LMU hardware fault monitoring
 driver

Hi Guenter,

On 11/2/2015 11:27 PM, Guenter Roeck wrote:
> On 11/01/2015 09:24 PM, Milo Kim wrote:
>> LM3633 and LM3697 are TI LMU MFD device.
>> Those device have hardware monitoring feature which detects opened or
>> shorted circuit case.
>>
> Sure, but it only makes sense if you provide standard hwmon attributes
> which can be interpreted by the "sensors" command. Which is not the case
> here. You neither have a standard device type (light is not handled by hwmon),
> nor standard attributes, nor do the attributes return standard values.
>
> I think there may be a basic misunderstanding. hwmon is not intended
> to monitor a specific chip on the board. Its scope is to monitor the
> system (such as temperature, voltages, or current).
>
> In your case, it might be better to attach the attributes to the mfd device.
>

OK, got your point. Thanks a lot for your suggestion.

Best regards,
Milo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/