linux-kernel - Re: [PATCH] mfd: cros ec: Lock the SPI bus while holding chipselect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANMq1KA4BOJ-k=JNSfXN1aPxctvX6R+oZj4eyg9gbpqXOWJ=6g@mail.gmail.com>
Date:	Tue, 3 Nov 2015 16:25:48 +0800
From:	Nicolas Boichat <drinkcat@...omium.org>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	linux-kernel@...r.kernel.org,
	Javier Martinez Canillas <javier@....samsung.com>,
	Olof Johansson <olof@...om.net>,
	Douglas Anderson <dianders@...omium.org>,
	Randall Spangler <rspangler@...omium.org>,
	Gwendal Grignou <gwendal@...omium.org>
Subject: Re: [PATCH] mfd: cros ec: Lock the SPI bus while holding chipselect

+gwendal@...omium.org

On Thu, Oct 29, 2015 at 4:17 PM, Nicolas Boichat <drinkcat@...omium.org> wrote:
> @@ -482,6 +493,7 @@ static int cros_ec_pkt_xfer_spi(struct cros_ec_device *ec_dev,
>
>         ret = len;
>  exit:
> +       spi_bus_unlock(ec_spi->spi->master);

Gwendal noted offline that I could unlock the bus earlier, just after
terminate_request.

I'll do that and send a v2 soon.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/