linux-kernel - [PATCH] recordmcount: fix endianness handling bug for nop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <563806C7.7070606@huawei.com>
Date:	Tue, 3 Nov 2015 08:58:47 +0800
From:	libin <huawei.libin@...wei.com>
To:	Steven Rostedt <rostedt@...dmis.org>
CC:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	<will.deacon@....com>, <lkp@...el.com>, <catalin.marinas@....com>,
	<takahiro.akashi@...aro.org>, <zhouchengming1@...wei.com>,
	<xiexiuqi@...wei.com>, <guohanjun@...wei.com>,
	<linux-kernel@...r.kernel.org>, <dingtianhong@...wei.com>,
	<linux-arm-kernel@...ts.infradead.org>
Subject: [PATCH] recordmcount: fix endianness handling bug for nop_mcount

In nop_mcount, shdr->sh_offset and welp->r_offset should handle
endianness properly, otherwise it will trigger Segmentation fault
if the recordmcount main and file.o have different endianness.

Cc: <stable@...r.kernel.org> # 3.0+
Signed-off-by: Li Bin <huawei.libin@...wei.com>
---
 scripts/recordmcount.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/scripts/recordmcount.h b/scripts/recordmcount.h
index 49b582a..b9897e2 100644
--- a/scripts/recordmcount.h
+++ b/scripts/recordmcount.h
@@ -377,7 +377,7 @@ static void nop_mcount(Elf_Shdr const *const relhdr,

 		if (mcountsym == Elf_r_sym(relp) && !is_fake_mcount(relp)) {
 			if (make_nop)
-				ret = make_nop((void *)ehdr, shdr->sh_offset + relp->r_offset);
+				ret = make_nop((void *)ehdr, _w(shdr->sh_offset) + _w(relp->r_offset));
 			if (warn_on_notrace_sect && !once) {
 				printf("Section %s has mcount callers being ignored\n",
 				       txtname);
-- 
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/