linux-kernel - Re: [PATCH V4] usb: remove unnecessary CONFIG_PM dependency from USB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8737wnnq3c.fsf@saruman.tx.rr.com>
Date:	Tue, 3 Nov 2015 07:56:55 -0600
From:	Felipe Balbi <balbi@...com>
To:	Nathan Sullivan <nathan.sullivan@...com>,
	<gregkh@...uxfoundation.org>
CC:	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	Nathan Sullivan <nathan.sullivan@...com>
Subject: Re: [PATCH V4] usb: remove unnecessary CONFIG_PM dependency from USB_OTG


Hi,

Nathan Sullivan <nathan.sullivan@...com> writes:
> The USB OTG support currently depends on power management
> (CONFIG_PM) being enabled, but does not actually need it enabled.
> Remove this dependency.
>
> Tested on Bay Trail hardware with dwc3 USB.
>
> Signed-off-by: Nathan Sullivan <nathan.sullivan@...com>
> ---
>  drivers/usb/core/Kconfig |    1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/core/Kconfig b/drivers/usb/core/Kconfig
> index a99c89e..9c5cdf3 100644
> --- a/drivers/usb/core/Kconfig
> +++ b/drivers/usb/core/Kconfig
> @@ -43,7 +43,6 @@ config USB_DYNAMIC_MINORS
>  
>  config USB_OTG
>  	bool "OTG support"
> -	depends on PM

I don't think this is correct. OTG depends on USB bus suspend, which is
only available on PM builds. Care to further detail why you think PM is
not needed on OTG ?

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (819 bytes)