linux-kernel - [PATCH] PCI: altera: add OF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 03 Nov 2015 15:08:33 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	Ley Foon Tan <lftan@...era.com>,
	Marc Zyngier <marc.zyngier@....com>
Subject: [PATCH] PCI: altera: add OF_PCI dependency

The newly added altera PCI driver fails to build when CONFIG_OF
is disabled:

drivers/pci/host/pcie-altera.c: In function 'altera_pcie_parse_request_of_pci_ranges':
drivers/pci/host/pcie-altera.c:420:8: error: implicit declaration of function 'of_pci_get_host_bridge_resources' [-Werror=implicit-function-declaration]

This adds a dependency on OF_PCI for clarity, this is the symbol
that guards the implementation of of_pci_get_host_bridge_resources.

Signed-off-by: Arnd Bergmann <arnd@...db.de>
Fixes: 6bb4dd154ae8 ("PCI: altera: Add Altera PCIe host controller driver")
---
Found on ARM randconfig builds yesterday

diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
index 9e24075d83f7..f131ba947dc6 100644
--- a/drivers/pci/host/Kconfig
+++ b/drivers/pci/host/Kconfig
@@ -150,6 +150,7 @@ config PCIE_IPROC_BCMA
 config PCIE_ALTERA
 	bool "Altera PCIe controller"
 	depends on ARM || NIOS2
+	depends on OF_PCI
 	select PCI_DOMAINS
 	help
 	  Say Y here if you want to enable PCIe controller support on Altera

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/