linux-kernel - Re: [PATCH 1/4] Input: tsc2005 - Separate SPI and core functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151103014946.GB32018@dtor-ws>
Date:	Mon, 2 Nov 2015 17:49:46 -0800
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Michael Welling <mwelling@...e.org>
Cc:	kbuild test robot <lkp@...el.com>, kbuild-all@...org,
	Tony Lindgren <tony@...mide.com>, Pavel Machek <pavel@....cz>,
	Felipe Balbi <balbi@...com>,
	Sebastian Reichel <sre@...nel.org>,
	Roger Quadros <rogerq@...com>, Arnd Bergmann <arnd@...db.de>,
	Mark Brown <broonie@...nel.org>, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org
Subject: Re: [PATCH 1/4] Input: tsc2005 - Separate SPI and core functions

On Fri, Oct 30, 2015 at 07:41:23PM -0500, Michael Welling wrote:
> This patch separates the SPI functionality from core functionality
> that overlaps with the tsc2004.
> 
> Prepares kernel for new tsc2004 driver without much redundant code.
> 
> Signed-off-by: Michael Welling <mwelling@...e.org>
> ---
>  drivers/input/touchscreen/Kconfig                  |   4 +
>  drivers/input/touchscreen/Makefile                 |   1 +
>  drivers/input/touchscreen/tsc2005.c                | 709 +--------------------
>  .../touchscreen/{tsc2005.c => tsc200x-core.c}      | 226 ++-----
>  drivers/input/touchscreen/tsc200x-core.h           |  78 +++
>  5 files changed, 162 insertions(+), 856 deletions(-)
>  copy drivers/input/touchscreen/{tsc2005.c => tsc200x-core.c} (72%)
>  create mode 100644 drivers/input/touchscreen/tsc200x-core.h

This was giving me:

Kernel: arch/x86/boot/bzImage is ready  (#1451)
  MODPOST 1447 modules
ERROR: "tsc200x_regmap_config" [drivers/input/touchscreen/tsc2005.ko] undefined!
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2

I'll fix it up locally by exporting the symbol.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/