linux-kernel - RE: [PATCH v1 02/20] clocksource: Add NPS400 timers driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 3 Nov 2015 15:18:15 +0000
From:	Noam Camus <noamc@...hip.com>
To:	Vineet Gupta <Vineet.Gupta1@...opsys.com>,
	"linux-snps-arc@...ts.infradead.org" 
	<linux-snps-arc@...ts.infradead.org>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Tal Zilcer <talz@...hip.com>, Gil Fruchter <gilf@...hip.com>,
	Chris Metcalf <cmetcalf@...hip.com>,
	Daniel Lezcano <daniel.lezcano@...aro.org>,
	"Rob Herring" <robh+dt@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"John Stultz" <john.stultz@...aro.org>
Subject: RE: [PATCH v1 02/20] clocksource: Add NPS400 timers driver

From: Vineet Gupta [mailto:Vineet.Gupta1@...opsys.com] 
Sent: Monday, November 02, 2015 1:04 PM

>> +
>> +	upper = ioread32be(upper_p);

>Consider using the _relaxed macros even if your platform doesn't have specific IO barriers.
[Noam Camus] What is the big endian flavor for _relaxed macros.
 
>> +	counter = upper;
>> +	counter <<= 32;
>> +	counter |= lower;

>It is easier to read:

>counter = (upper << 32) | lower;

Thanks I will update

- Noam

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/