linux-kernel - Re: [PATCH] ssb: mark ssb_bus_register as __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7423389.1hNz9LlOCE@wuerfel>
Date:	Tue, 03 Nov 2015 17:42:26 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Michael Büsch <m@...s.ch>
Cc:	netdev@...r.kernel.org, Kalle Valo <kvalo@...eaurora.org>,
	linux-kernel@...r.kernel.org, zajec5@...il.com,
	Nicolas Ferre <nicolas.ferre@...el.com>,
	Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>
Subject: Re: [PATCH] ssb: mark ssb_bus_register as __maybe_unused

On Tuesday 03 November 2015 17:27:21 Michael Büsch wrote:
> On Tue, 03 Nov 2015 16:05:51 +0100
> Arnd Bergmann <arnd@...db.de> wrote:
> 
> > The SoC variant of the ssb code is now optional like the other
> > ones, which means we can build the framwork without any
> > front-end, but that results in a warning:
> > 
> > drivers/ssb/main.c:616:12: warning: 'ssb_bus_register' defined but not used [-Wunused-function]
> > 
> > This annotates the ssb_bus_register function as __maybe_unused to
> > shut up the warning. A configuration like this will not work on
> > any hardware of course, but we still want this to silently build
> > without warnings if the configuration is allowed in the first
> > place.
> 
> 
> Is there a simple way to disallow this configuration?

I could not come up with a simple one. We could turn 'CONFIG_SSB' into
a silent option and have it selected by each bus specific driver,
but then we also have to change all the device drivers (usb and
wireless I guess) to use 'depends on' rather than 'select'.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/