linux-kernel - Re: [PATCH v2] regulator: of: removing two variables min_uV and max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151103172910.GR20228@sirena.org.uk>
Date:	Tue, 3 Nov 2015 17:29:11 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Saurabh Sengar <saurabh.truth@...il.com>
Cc:	linux-kernel@...r.kernel.org, lgirdwood@...il.com
Subject: Re: [PATCH v2] regulator: of: removing two variables min_uV and
 max_uV

On Mon, Nov 02, 2015 at 03:18:00PM +0530, Saurabh Sengar wrote:
> replacing the of_get_property function with of_property_read_u32 function
> as its help removing two variables.

> I have put these check back, please let me know if this v2 patch is worth

It's a bit marginal TBH and...

>  	/* Only one voltage?  Then make sure it's set. */
> -	if (min_uV && max_uV && constraints->min_uV == constraints->max_uV)
> +	if (constraints->min_uV && constraints->max_uV
> +			&& constraints->min_uV == constraints->max_uV)
>  		constraints->apply_uV = true;

...this does disallow a constraint of 0-XuV which was previously legal
and potentially meaningful.  Hrm.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)