linux-kernel - Re: [PATCH v10 2/5] missing include in cputime.c, remove #ifdef CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1511031753410.13541@kaball.uk.xensource.com>
Date:	Tue, 3 Nov 2015 17:56:34 +0000
From:	Stefano Stabellini <stefano.stabellini@...citrix.com>
To:	kbuild test robot <lkp@...el.com>
CC:	Stefano Stabellini <stefano.stabellini@...citrix.com>,
	<kbuild-all@...org>, <xen-devel@...ts.xensource.com>,
	<linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>, <konrad.wilk@...cle.com>,
	<marc.zyngier@....com>, <will.deacon@....com>,
	<Ian.Campbell@...rix.com>, <linux@....linux.org.uk>,
	<olof@...om.net>, <arnd@...db.de>, <catalin.marinas@....com>,
	<mingo@...hat.com>, <peterz@...radead.org>
Subject: Re: [PATCH v10 2/5] missing include in cputime.c, remove #ifdef
 CONFIG_PARAVIRT from sched/core.c

On Wed, 4 Nov 2015, kbuild test robot wrote:
> Hi Stefano,
> 
> [auto build test ERROR on arm64/for-next/core]
> [cannot apply to: xen-tip/linux-next]
> [also ERROR on: v4.3 next-20151103]
> 
> url:    https://github.com/0day-ci/linux/commits/Stefano-Stabellini/xen-arm-arm64-CONFIG_PARAVIRT-and-stolen-ticks-accounting/20151104-002433
> base:   https://github.com/0day-ci/linux Stefano-Stabellini/xen-arm-arm64-CONFIG_PARAVIRT-and-stolen-ticks-accounting/20151104-002433
> config: mips-jz4740 (attached as .config)

Ah, of course! I only tested x86, arm and arm64, but this wouldn't work
on any arches without arm/paravirt.h. Damn.

I guess we'll have to keep

#ifdef CONFIG_PARAVIRT
#include <asm/paravirt.h>
#endif


BTW this auto build test is awesome.

> reproduce:
>         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # save the attached .config to linux build tree
>         make.cross ARCH=mips 
> 
> All errors (new ones prefixed by >>):
> 
> >> kernel/sched/core.c:82:26: fatal error: asm/paravirt.h: No such file or directory
>    compilation terminated.
> --
> >> kernel/sched/cputime.c:8:26: fatal error: asm/paravirt.h: No such file or directory
>    compilation terminated.
> 
> vim +82 kernel/sched/core.c
> 
> 52f5684c kernel/sched/core.c Gideon Israel Dsouza  2014-04-07  76  #include <linux/compiler.h>
> ^1da177e kernel/sched.c      Linus Torvalds        2005-04-16  77  
> 96f951ed kernel/sched/core.c David Howells         2012-03-28  78  #include <asm/switch_to.h>
> 5517d86b kernel/sched.c      Eric Dumazet          2007-05-08  79  #include <asm/tlb.h>
> 838225b4 kernel/sched.c      Satyam Sharma         2007-10-24  80  #include <asm/irq_regs.h>
> db7e527d kernel/sched/core.c Christian Borntraeger 2012-01-11  81  #include <asm/mutex.h>
> e6e6685a kernel/sched.c      Glauber Costa         2011-07-11 @82  #include <asm/paravirt.h>
> ^1da177e kernel/sched.c      Linus Torvalds        2005-04-16  83  
> 029632fb kernel/sched.c      Peter Zijlstra        2011-10-25  84  #include "sched.h"
> ea138446 kernel/sched/core.c Tejun Heo             2013-01-18  85  #include "../workqueue_internal.h"
> 
> :::::: The code at line 82 was first introduced by commit
> :::::: e6e6685accfa81f509fadfc9624bc7c3862d75c4 KVM guest: Steal time accounting
> 
> :::::: TO: Glauber Costa <glommer@...hat.com>
> :::::: CC: Avi Kivity <avi@...hat.com>
> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/