linux-kernel - Re: [PATCH 2/2] pstore: fix code comment to match code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGXu5jLNJ0_Pb1UssDVz4O6BGTHeMcdVOa3rPVOaLaXRxkFahg@mail.gmail.com>
Date:	Tue, 3 Nov 2015 12:05:32 -0800
From:	Kees Cook <keescook@...omium.org>
To:	Geliang Tang <geliangtang@....com>
Cc:	Anton Vorontsov <anton@...msg.org>,
	Colin Cross <ccross@...roid.com>,
	Tony Luck <tony.luck@...el.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] pstore: fix code comment to match code

On Sat, Oct 31, 2015 at 8:23 AM, Geliang Tang <geliangtang@....com> wrote:
> Fix code comment about kmsg_dump register so it matches the code.
>
> Signed-off-by: Geliang Tang <geliangtang@....com>

Acked-by: Kees Cook <keescook@...omium.org>

-Kees

> ---
>  fs/pstore/platform.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/fs/pstore/platform.c b/fs/pstore/platform.c
> index 0aab920..588461b 100644
> --- a/fs/pstore/platform.c
> +++ b/fs/pstore/platform.c
> @@ -361,6 +361,9 @@ static struct kmsg_dumper pstore_dumper = {
>         .dump = pstore_dump,
>  };
>
> +/*
> + * Register with kmsg_dump to save last part of console log on panic.
> + */
>  static void pstore_register_kmsg(void)
>  {
>         kmsg_dump_register(&pstore_dumper);
> @@ -434,8 +437,6 @@ static int pstore_write_compat(enum pstore_type_id type,
>   * read function right away to populate the file system. If not
>   * then the pstore mount code will call us later to fill out
>   * the file system.
> - *
> - * Register with kmsg_dump to save last part of console log on panic.
>   */
>  int pstore_register(struct pstore_info *psi)
>  {
> --
> 2.4.3
>
>



-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/