linux-kernel - Re: [PATCH 4/4] Input: tsc2004

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 3 Nov 2015 15:30:50 -0800
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Michael Welling <mwelling@...e.org>
Cc:	Rob Herring <robh@...nel.org>, kbuild test robot <lkp@...el.com>,
	kbuild-all@...org, Tony Lindgren <tony@...mide.com>,
	Pavel Machek <pavel@....cz>, Felipe Balbi <balbi@...com>,
	Sebastian Reichel <sre@...nel.org>,
	Roger Quadros <rogerq@...com>, Arnd Bergmann <arnd@...db.de>,
	Mark Brown <broonie@...nel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>
Subject: Re: [PATCH 4/4] Input: tsc2004 - Document ts2004 dt bindings

On Tue, Nov 03, 2015 at 05:11:56PM -0600, Michael Welling wrote:
> On Tue, Nov 03, 2015 at 02:59:13PM -0800, Dmitry Torokhov wrote:
> > On Tue, Nov 03, 2015 at 09:41:17AM -0600, Michael Welling wrote:
> > > On Tue, Nov 03, 2015 at 09:31:10AM -0600, Rob Herring wrote:
> > > > On Tue, Nov 3, 2015 at 1:21 AM, Dmitry Torokhov
> > > > <dmitry.torokhov@...il.com> wrote:
> > > > > On Mon, Nov 02, 2015 at 02:50:29PM -0600, Michael Welling wrote:
> > > > >> On Mon, Nov 02, 2015 at 09:19:50AM -0600, Rob Herring wrote:
> > > > >> > > +Required properties:
> > > > >> > > + - compatible                : "ti,tsc2004"
> > > > >> > > + - interrupts                : IRQ specifier
> > > > >> > > + - vio-supply                 : Regulator specifier
> > > > >> >
> > > > >> > reg property?
> > > > >>
> > > > >> Rob,
> > > > >>
> > > > >> It appears that I missed this in the description.
> > > > >>
> > > > >> Probably because I was following the lead of the ts2005 description.
> > > > >>
> > > > >> How does this look:
> > > > >> - reg                 : I2C address. 0x48 - 0x4b based on the voltage applied to
> > > > >>                         the AD1 and AD0 inputs on the IC.
> > > > >>
> > > > >
> > > > > How about the version below?
> > > > >
> > > > > Thanks.
> > > > >
> > > > > --
> > > > > Dmitry
> > > > >
> > > > >
> > > > > Input: tsc2004 - document ts2004 dt bindings
> > > 
> > > Just noticed that it says ts2004 instead of tsc2004 in the subject.
> > > Otherwise, I am fine with it.
> > > 
> > > Thanks for the assistance.
> > > 
> > > Still no acks or reviews for the other patches in the series.
> > > I would like for someone to test the tsc2005 support to see if it still works.
> > > 
> > > The tsc2004 works very well on the target that I have here.
> > 
> > I folded this patch into the patch #3 and applied everything.
> >
> 
> Great.
> 
> Will this patch series conflict with the patch series to take out the .owner=THIS_MODULE
> from spi_drivers?
> 
> https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1004626.html

If he tries to get them in one pass - probably, but the conflicts should
be trivial and should be easily resolved by SPI maintainer and/or Linus.

Or he could split the patch per-subsystem.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/