linux-kernel - Re: [PATCH 3/8] arch: uapi: asm: mman.h: Let MADV_FREE have same value for all architectures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151103023250.GH17906@bbox>
Date:	Tue, 3 Nov 2015 11:32:51 +0900
From:	Minchan Kim <minchan@...nel.org>
To:	Hugh Dickins <hughd@...gle.com>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	Michael Kerrisk <mtk.manpages@...il.com>,
	linux-api@...r.kernel.org, Johannes Weiner <hannes@...xchg.org>,
	zhangyanfei@...fujitsu.com, Rik van Riel <riel@...hat.com>,
	Mel Gorman <mgorman@...e.de>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	David Miller <davem@...emloft.net>,
	"Darrick J. Wong" <darrick.wong@...cle.com>,
	Roland Dreier <roland@...nel.org>, Jason Evans <je@...com>,
	Daniel Micay <danielmicay@...il.com>,
	"Kirill A. Shutemov" <kirill@...temov.name>,
	Michal Hocko <mhocko@...e.cz>, yalin.wang2010@...il.com,
	Shaohua Li <shli@...nel.org>,
	Chen Gang <gang.chen.5i5j@...il.com>,
	"rth@...ddle.net" <rth@...ddle.net>,
	"ink@...assic.park.msu.ru" <ink@...assic.park.msu.ru>,
	"mattst88@...il.com" <mattst88@...il.com>,
	Ralf Baechle <ralf@...ux-mips.org>,
	"jejb@...isc-linux.org" <jejb@...isc-linux.org>,
	"deller@....de" <deller@....de>,
	"chris@...kel.net" <chris@...kel.net>,
	"jcmvbkbc@...il.com" <jcmvbkbc@...il.com>,
	Arnd Bergmann <arnd@...db.de>, sparclinux@...r.kernel.org,
	linux-arch@...r.kernel.org
Subject: Re: [PATCH 3/8] arch: uapi: asm: mman.h: Let MADV_FREE have same
 value for all architectures

On Sun, Nov 01, 2015 at 04:08:27PM -0800, Hugh Dickins wrote:
> On Fri, 30 Oct 2015, Minchan Kim wrote:
> > From: Chen Gang <gang.chen.5i5j@...il.com>
> > 
> > For uapi, need try to let all macros have same value, and MADV_FREE is
> > added into main branch recently, so need redefine MADV_FREE for it.
> > 
> > At present, '8' can be shared with all architectures, so redefine it to
> > '8'.
> > 
> > Cc: rth@...ddle.net <rth@...ddle.net>,
> > Cc: ink@...assic.park.msu.ru <ink@...assic.park.msu.ru>
> > Cc: mattst88@...il.com <mattst88@...il.com>
> > Cc: Ralf Baechle <ralf@...ux-mips.org>
> > Cc: jejb@...isc-linux.org <jejb@...isc-linux.org>
> > Cc: deller@....de <deller@....de>
> > Cc: chris@...kel.net <chris@...kel.net>
> > Cc: jcmvbkbc@...il.com <jcmvbkbc@...il.com>
> > Cc: Arnd Bergmann <arnd@...db.de>
> > Cc: linux-arch@...r.kernel.org
> > Cc: linux-api@...r.kernel.org
> > Acked-by: Minchan Kim <minchan@...nel.org>
> > Signed-off-by: Chen Gang <gang.chen.5i5j@...il.com>
> 
> Let me add
> Acked-by: Hugh Dickins <hughd@...gle.com>
> to this one too.
> 
> But I have extended your mail's Cc list: Darrick pointed out earlier
> that dietlibc has a Solaris #define MADV_FREE 0x5 in its mman.h,
> and that was in the kernel's sparc mman.h up until 2.6.25.  I doubt
> that presents any obstacle nowadays, but Dave Miller should be Cc'ed.
> 
> I was a little suspicious that 8 is available for MADV_FREE: why did
> the common/generic parameters start at 9 instead of 8 back in 2.6.16?
> I think the answer is that we had MADV_REMOVE coming in from one
> direction, and MADV_DONTFORK coming from another direction, and when
> Roland looked for where to start the commons for MADV_DONTFORK, it
> appeared that 8 was occupied - by MADV_REMOVE; then a little later
> MADV_REMOVE was shifted to become the first of the commons, at 9.

Thanks for Ack, Ccing relevant people and history!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/