linux-kernel - Re: [PATCH v1 2/4] clk: rockchip: set an id for crypto clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151104100802.22783.97388@quantum>
Date:	Wed, 04 Nov 2015 02:08:02 -0800
From:	Michael Turquette <mturquette@...libre.com>
To:	Zain Wang <zain.wang@...k-chips.com>, zhengsq@...k-chips.com,
	hl@...k-chips.com, herbert@...dor.apana.org.au,
	davem@...emloft.net, heiko@...ech.de, pawel.moll@....com,
	ijc+devicetree@...lion.org.uk, robh+dt@...nel.org,
	galak@...eaurora.org, linux@....linux.org.uk, mark.rutland@....com
Cc:	linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
	linux-rockchip@...ts.infradead.org, devicetree@...r.kernel.org,
	eddie.cai@...k-chips.com, "Zain Wang" <zain.wang@...k-chips.com>
Subject: Re: [PATCH v1 2/4] clk: rockchip: set an id for crypto clk

Quoting Zain Wang (2015-11-02 21:52:06)
> set an id for crypto clk, so that it can be called in other part.
> 
> Signed-off-by: Zain Wang <zain.wang@...k-chips.com>

Looks good to me. I can apply after -rc1 drops, or if you prefer to take
this series all together then you have my ack:

Acked-by: Michael Turquette <mturquette@...libre.com>

Regards,
Mike

> ---
>  drivers/clk/rockchip/clk-rk3288.c      | 2 +-
>  include/dt-bindings/clock/rk3288-cru.h | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/rockchip/clk-rk3288.c b/drivers/clk/rockchip/clk-rk3288.c
> index 9040878..3fceda1 100644
> --- a/drivers/clk/rockchip/clk-rk3288.c
> +++ b/drivers/clk/rockchip/clk-rk3288.c
> @@ -295,7 +295,7 @@ static struct rockchip_clk_branch rk3288_clk_branches[] __initdata = {
>                         RK3288_CLKGATE_CON(0), 4, GFLAGS),
>         GATE(0, "c2c_host", "aclk_cpu_src", 0,
>                         RK3288_CLKGATE_CON(13), 8, GFLAGS),
> -       COMPOSITE_NOMUX(0, "crypto", "aclk_cpu_pre", 0,
> +       COMPOSITE_NOMUX(SCLK_CRYPTO, "crypto", "aclk_cpu_pre", 0,
>                         RK3288_CLKSEL_CON(26), 6, 2, DFLAGS,
>                         RK3288_CLKGATE_CON(5), 4, GFLAGS),
>         GATE(0, "aclk_bus_2pmu", "aclk_cpu_pre", CLK_IGNORE_UNUSED,
> diff --git a/include/dt-bindings/clock/rk3288-cru.h b/include/dt-bindings/clock/rk3288-cru.h
> index c719aac..30dcd60 100644
> --- a/include/dt-bindings/clock/rk3288-cru.h
> +++ b/include/dt-bindings/clock/rk3288-cru.h
> @@ -86,6 +86,7 @@
>  #define SCLK_USBPHY480M_SRC    122
>  #define SCLK_PVTM_CORE         123
>  #define SCLK_PVTM_GPU          124
> +#define SCLK_CRYPTO                    125
>  
>  #define SCLK_MAC               151
>  #define SCLK_MACREF_OUT                152
> -- 
> 1.9.1
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/