linux-kernel - Re: [PATCH] toshiba_acpi: Initialize hotkey_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151104004439.GB4650@malice.jf.intel.com>
Date:	Tue, 3 Nov 2015 16:44:39 -0800
From:	Darren Hart <dvhart@...radead.org>
To:	Azael Avalos <coproscefalo@...il.com>
Cc:	"platform-driver-x86@...r.kernel.org" 
	<platform-driver-x86@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	stable@...r.kernel.org
Subject: Re: [PATCH] toshiba_acpi: Initialize hotkey_event_type variable

On Sun, Nov 01, 2015 at 07:30:30PM -0700, Azael Avalos wrote:
> Commit 23f8f4326a15 ("toshiba_acpi: Fix hotkeys registration on some
> toshiba models") fixed an issue on some laptops regarding hotkeys
> registration, however, if failed to address the initialization of the
> hotkey_event_type variable, and thus, it can lead to potential
> unwanted effects as the variable is being checked.
> 
> This patch initializes such variable to avoid such unwanted effects.
> 
> Cc: <stable@...r.kernel.org> # 4.1+
> Signed-off-by: Azael Avalos <coproscefalo@...il.com>
> ---
> Darren,
> 
> Sorry for sending this patch this late, I had a really busy week :-(

It's a trivial patch, so I'm not concerned with the timing. Thanks for getting
it out!

Unfortunately, it doesn't apply and appears to be whitespace mangled. Checkpatch
complains and tabs appear to have been replaced with spaces. Please check your
send mail mechanism and resend - possibly using git-send-email or something like
mutt -H PATCHNAME. Try sending to yourself first and verifying you can apply it.

Thanks,

> 
>  drivers/platform/x86/toshiba_acpi.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/toshiba_acpi.c
> b/drivers/platform/x86/toshiba_acpi.c
> index beb709f..c013029 100644
> --- a/drivers/platform/x86/toshiba_acpi.c
> +++ b/drivers/platform/x86/toshiba_acpi.c
> @@ -2665,6 +2665,7 @@ static int toshiba_acpi_add(struct acpi_device *acpi_dev)
>   ret = toshiba_function_keys_get(dev, &dev->special_functions);
>   dev->kbd_function_keys_supported = !ret;
> 
> + dev->hotkey_event_type = 0;
>   if (toshiba_acpi_setup_keyboard(dev))
>   pr_info("Unable to activate hotkeys\n");
> 
> -- 
> 2.6.2
> 

-- 
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/