linux-kernel - Re: [PATCH 0/3] cpuidle: small improvements & fixes for menu governor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <563A0FF3.40604@intel.com>
Date:	Wed, 4 Nov 2015 15:02:27 +0100
From:	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>
To:	Joe Perches <joe@...ches.com>, Rik van Riel <riel@...hat.com>,
	linux-kernel@...r.kernel.org
Cc:	arjan@...ux.intel.com, khilman@...com, len.brown@...el.com,
	daniel.lezcano@...aro.org, javi.merino@....com,
	tuukka.tikkanen@...aro.org
Subject: Re: [PATCH 0/3] cpuidle: small improvements & fixes for menu governor

On 11/4/2015 7:56 AM, Joe Perches wrote:
> On Wed, 2015-11-04 at 00:03 +0100, Rafael J. Wysocki wrote:
>> On 11/3/2015 11:35 PM, Rik van Riel wrote:
>>> On 11/03/2015 05:05 PM, Rafael J. Wysocki wrote:
>>>> On 10/28/2015 11:46 PM, riel@...hat.com wrote:
>>>>> While working on a paravirt cpuidle driver for KVM guests, I
>>>>> noticed a number of small logic errors in the menu governor
>>>>> code.
>>>>>
>>>>> These patches should get rid of some artifacts that can break
>>>>> the logic in the menu governor under certain corner cases, and
>>>>> make idle state selection work better on CPUs with long C1 exit
>>>>> latencies.
>>>>>
>>>>> I have not seen any adverse effects with them in my (quick)
>>>>> tests. As expected, they do not seem to do much on systems with
>>>>> many power states and very low C1 exit latencies and target
>>>>> residencies.
>>>>>
>>>> Sorry for the trouble, but can you please resend the series with
>>>> CCs to
>>>> linux-pm@...r.kernel.org?  That will make it way easier to handle
>>>> for me.
>>> Not a problem. Done.
>>>
>>> What change do I need to send in to ensure that the
>>> linux-pm mailing list shows up in get_maintainer.pl
>>> output?
>>>
>>> $ ./scripts/get_maintainer.pl -f drivers/cpuidle/governors/menu.c
>>> "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>
>>> (commit_signer:4/7=57%,authored:1/7=14%,added_lines:2/19=11%,remove
>>> d_lines:2/28=7%)
>>> Daniel Lezcano <daniel.lezcano@...aro.org>
>>> (commit_signer:3/7=43%,authored:1/7=14%,added_lines:1/19=5%)
>>> Rik van Riel <riel@...hat.com>
>>> (commit_signer:3/7=43%,authored:3/7=43%,added_lines:5/19=26%,remove
>>> d_lines:3/28=11%)
>>> Len Brown <len.brown@...el.com>
>>> (commit_signer:1/7=14%,authored:1/7=14%,added_lines:10/19=53%,remov
>>> ed_lines:15/28=54%)
>>> "Peter Zijlstra (Intel)" <peterz@...radead.org>
>>> (commit_signer:1/7=14%)
>>> Javi Merino <javi.merino@....com>
>>> (authored:1/7=14%,added_lines:1/19=5%,removed_lines:7/28=25%)
>>> linux-kernel@...r.kernel.org (open list)
>>>
>> I'm not sure why it doesn't show up in there.
>> If you look at MAINTAINERS under CPUIDLE DRIVERS, linux-pm is
>> actually listed there.
> Because the pattern is just the files in the top level directory
> of drivers/cpuidle and not any files in any directory below
>
>  From the MAINTAINERS pattern descriptions:
>
> 	F: Files and directories with wildcard patterns.
> 	   A trailing slash includes all files and subdirectory files.
> 	   F:	drivers/net/	all files in and below
> drivers/net
> 	   F:	drivers/net/*	all files in drivers/net, but
> not below
>
>> Maybe the answer is that get_maintainer.pl needs to be fixed ...
> Nope, the MAINTAINERS - CPUIDLE DRIVERS entry does though.

OK, I see.

Care to send this patch with a proper changelog/sign-off?

> ---
>   MAINTAINERS | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 77ed3a0..8bd5c7e 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3004,7 +3004,7 @@ M:	Daniel Lezcano <daniel.lezcano@...aro.org>
>   L:	linux-pm@...r.kernel.org
>   S:	Maintained
>   T:	git git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git
> -F:	drivers/cpuidle/*
> +F:	drivers/cpuidle/
>   F:	include/linux/cpuidle.h
>   
>   CPUID/MSR DRIVER
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/