| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20151104141715.GB10124@quack.suse.cz> Date: Wed, 4 Nov 2015 15:17:15 +0100 From: Jan Kara <jack@...e.cz> To: Christoph Hellwig <hch@...radead.org> Cc: Jan Kara <jack@...e.com>, axboe@...nel.dk, LKML <linux-kernel@...r.kernel.org>, linux-fsdevel@...r.kernel.org Subject: Re: [PATCH] block: Don't allow illegal discard requests On Wed 04-11-15 03:30:19, Christoph Hellwig wrote: > On Wed, Nov 04, 2015 at 10:18:41AM +0100, Jan Kara wrote: > > Currently blkdev_issue_discard() doesn't check that submitted discard > > request matches granularity required by the underlying device. > > Submitting such requests to the device can have unexpected consequences > > (e.g. brd driver just discards more / less data depending on how exactly > > the request is aligned). So test that submitted discard request has the > > granularity required by the driver. > > How is this going to work with stacked drivers? I think brd needs to > be fixed to take care of the granularity itself, just like we did for > request based drivers. So you mean that a stacked driver would split a discard request so that it is no longer of the required granularity? OK, makes sense. I'll add the check directly into brd itself. Honza -- Jan Kara <jack@...e.com> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists