linux-kernel - Re: perf related lockdep bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151104155110.GW29027@linux.vnet.ibm.com>
Date:	Wed, 4 Nov 2015 07:51:10 -0800
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	Dave Jones <davej@...emonkey.org.uk>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...hat.com>,
	Stephane Eranian <eranian@...il.com>,
	Andi Kleen <andi@...stfloor.org>
Subject: Re: perf related lockdep bug

On Wed, Nov 04, 2015 at 04:36:51PM +0100, Peter Zijlstra wrote:
> On Wed, Nov 04, 2015 at 03:20:58PM +0100, Peter Zijlstra wrote:
> > On Wed, Nov 04, 2015 at 05:48:38AM -0800, Paul E. McKenney wrote:
> > > This problem is caused by the IPI handler interrupting the RCU read-side
> > > critical section.  One way to prevent the IPI from doing this is to
> > > disable interrupts across the RCU read-side critical section instead
> > > of merely disabling preemption.  This is a reasonable approach given
> > > that acquiring the scheduler locks is going to disable interrupts
> > > in any case.
> > > 
> > > The (untested) patch below takes this approach.
> > > 
> > > Thoughts?
> > 
> > Yes, this should work, but now I worry I need to go audit all of perf
> > and sched for this :/
> 
> I can't find any other sites just now, so let me queue this.

Works for me, thank you!  It passes light rcutorture testing, but then
again so did the version without this commit.  :-/

I will queue the needed documentation updates separately.  I don't see
these as urgent, so probably next merge window.

> I also had a brief look if you used any other locks under rnp->lock, but
> aside from the printk and sched things it seems clean.

Whew!  ;-)

							Thanx, Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/