lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 4 Nov 2015 09:47:36 +0800 From: YH Huang <yh.huang@...iatek.com> To: Philipp Zabel <p.zabel@...gutronix.de> CC: <linux-pwm@...r.kernel.org>, <linux-fbdev@...r.kernel.org>, Jingoo Han <jingoohan1@...il.com>, Tomi Valkeinen <tomi.valkeinen@...com>, Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>, <linux-kernel@...r.kernel.org>, Thierry Reding <thierry.reding@...il.com>, <linux-mediatek@...ts.infradead.org>, Sascha Hauer <kernel@...gutronix.de>, Matthias Brugger <matthias.bgg@...il.com>, <yingjoe.chen@...iatek.com>, "Lee Jones" <lee.jones@...aro.org>, <linux-arm-kernel@...ts.infradead.org> Subject: Re: [PATCH v2] pwm-backlight: fix the panel power sequence On Tue, 2015-11-03 at 12:08 +0100, Philipp Zabel wrote: > Hi YH, > > Am Dienstag, den 03.11.2015, 16:11 +0800 schrieb YH Huang: > > > The reasoning is that devices where there is no phandle link pointing to > > > the backlight (for example from a simple-panel node), we should keep the > > > current default behaviour (enable during probe). > > > > I have a little problem for the current default behaviour. > > Should we enable during probe? > > Here I mean enabling the backlight (at the end of the probe function), > not enabling the GPIO already when requesting it. > > > Before this patch ( http://patchwork.ozlabs.org/patch/324690/ ), > > we disable "enable-gpio" in the probe function. > > While before this patch the GPIO would be initialized in the disabled > state, the call to backlight_update_status at the end of the probe > function would still enable the backlight afterwards. Based on this, could we disable it initially and update in the backlight_update_status function? Like this, if (pb->enable_gpio) { if (phandle && gpiod_get_direction(pb->enable_gpio) == GPIOF_DIR_OUT && gpiod_get_value(pb->enable_gpio) == 1) gpiod_direction_output(pb->enable_gpio, 1); else gpiod_direction_output(pb->enable_gpio, 0); } And then update with props.brightness in backlight_update_status. I am not sure, maybe I miss something. Regards, YH Huang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists