| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <563A6123.8030506@users.sourceforge.net> Date: Wed, 4 Nov 2015 20:48:51 +0100 From: SF Markus Elfring <elfring@...rs.sourceforge.net> To: linux-kernel@...r.kernel.org, Greg Kroah-Hartman <gregkh@...uxfoundation.org> Cc: kernel-janitors@...r.kernel.org, Julia Lawall <julia.lawall@...6.fr> Subject: [PATCH] sysfs: Delete an unnecessary check before the function call "kernfs_get" From: Markus Elfring <elfring@...rs.sourceforge.net> Date: Wed, 4 Nov 2015 20:44:50 +0100 The kernfs_get() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net> --- fs/sysfs/group.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/sysfs/group.c b/fs/sysfs/group.c index dc1358b..9b34c07 100644 --- a/fs/sysfs/group.c +++ b/fs/sysfs/group.c @@ -388,8 +388,7 @@ int __compat_only_sysfs_link_entry_to_kobj(struct kobject *kobj, */ spin_lock(&sysfs_symlink_target_lock); target = target_kobj->sd; - if (target) - kernfs_get(target); + kernfs_get(target); spin_unlock(&sysfs_symlink_target_lock); if (!target) return -ENOENT; -- 2.6.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists