[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <563AC69D.3070606@huawei.com>
Date: Thu, 5 Nov 2015 11:01:49 +0800
From: Zhong Kaihua <zhongkaihua@...wei.com>
To: Rob Herring <robh+dt@...nel.org>
CC: Pawel Moll <pawel.moll@....com>,
Mark Rutland <mark.rutland@....com>,
Ian Campbell <ijc+devicetree@...lion.org.uk>,
Kumar Gala <galak@...eaurora.org>,
Catalin Marinas <catalin.marinas@....com>,
"Will Deacon" <will.deacon@....com>,
Yiping Xu <xuyiping@...ilicon.com>,
Wei Xu <xuwei5@...ilicon.com>,
Bintian Wang <bintian.wang@...wei.com>,
"Haojian Zhuang" <haojian.zhuang@...aro.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Chen Feng <puck.chen@...ilicon.com>, <w.f@...wei.com>,
<dan.zhao@...ilicon.com>,
Xinwei Kong <kong.kongxinwei@...ilicon.com>
Subject: Re: [PATCH 2/3] dt-bindings: gpio: Documentation for Hi6220 gpio
driver
On 2015/11/2 23:09, Rob Herring wrote:
> On Fri, Oct 30, 2015 at 9:24 PM, Zhong Kaihua <zhongkaihua@...wei.com> wrote:
>> dt-bindings: gpio: Documentation for Hi6220 gpio driver
>>
>> Signed-off-by: Zhong Kaihua <zhongkaihua@...wei.com>
>> ---
>> .../devicetree/bindings/gpio/gpio-hi6220.txt | 23 ++++++++++++++++++++++
>> 1 file changed, 23 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/gpio/gpio-hi6220.txt
>>
>> diff --git a/Documentation/devicetree/bindings/gpio/gpio-hi6220.txt b/Documentation/devicetree/bindings/gpio/gpio-hi6220.txt
>> new file mode 100644
>> index 0000000..76a8932
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/gpio/gpio-hi6220.txt
>> @@ -0,0 +1,23 @@
>> +Hisilicon Hi6220 GPIO controller bindings
>> +
>> +Required properties:
>> + - compatible: "arm,pl061", "arm,primecell"
>> + - gpio-controller: Marks the device node as a GPIO controller.
>> + - #gpio-cells: Should be 2. See gpio.txt in this directory for a
>
> Some strange spacing in here. Otherwise,
>
> Acked-by: Rob Herring <robh@...nel.org>
Style problems have been fixed in V2 patch.
Rearrange the document patch to the first of patch set.
>
>> + description of the cells format.
>> + - interrupt-controller: Mark the device node as an interrupt controller
>> +
>> +Example:
>> +
>> + gpio0: gpio@...11000 {
>> + compatible = "arm,pl061", "arm,primecell";
>> + reg = <0x0 0xf8011000 0x0 0x1000>;
>> + interrupts = <0 52 0x4>;
>> + gpio-controller;
>> + #gpio-cells = <2>;
>> + interrupt-controller;
>> + #interrupt-cells = <2>;
>> + clocks = <&ao_ctrl 2>;
>> + clock-names = "apb_pclk";
>> + status = "ok";
>> + };
>> --
>> 1.9.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe devicetree" in
>> the body of a message to majordomo@...r.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> .
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists