[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1446698789-19308-3-git-send-email-okaya@codeaurora.org>
Date: Wed, 4 Nov 2015 23:46:28 -0500
From: Sinan Kaya <okaya@...eaurora.org>
To: linux-scsi@...r.kernel.org, timur@...eaurora.org,
cov@...eaurora.org, jcm@...hat.com
Cc: Sinan Kaya <okaya@...eaurora.org>,
Doug Gilbert <dgilbert@...erlog.com>,
"James E.J. Bottomley" <JBottomley@...n.com>,
linux-kernel@...r.kernel.org
Subject: [PATCH 3/4] scsi: fix compiler warning for sg
The MULDIV macro has been designed for small
numbers. It emits an overflow warning on 64 bit
systems. This patch places type casts in the
parameters to fix the compiler warning.
Signed-off-by: Sinan Kaya <okaya@...eaurora.org>
---
drivers/scsi/sg.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c
index 9d7b7db..eb2739d 100644
--- a/drivers/scsi/sg.c
+++ b/drivers/scsi/sg.c
@@ -88,7 +88,10 @@ static void sg_proc_cleanup(void);
* Of course an overflow is inavoidable if the result of muldiv doesn't fit
* in 32 bits.
*/
-#define MULDIV(X,MUL,DIV) ((((X % DIV) * MUL) / DIV) + ((X / DIV) * MUL))
+static inline u64 MULDIV(u64 X, u32 MUL, u32 DIV)
+{
+ return ((((X % DIV) * MUL) / DIV) + ((X / DIV) * MUL));
+}
#define SG_DEFAULT_TIMEOUT MULDIV(SG_DEFAULT_TIMEOUT_USER, HZ, USER_HZ)
--
Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists