linux-kernel - Re: [PATCH] spi: mediatek: single device does not require cs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANMq1KCXPjQuJUp3zOSVQQA29n9TT56Z0NPpD4o3O5s3o3nqSA@mail.gmail.com>
Date:	Thu, 5 Nov 2015 18:33:04 +0800
From:	Nicolas Boichat <drinkcat@...omium.org>
To:	Andy Shevchenko <andy.shevchenko@...il.com>
Cc:	Mark Brown <broonie@...nel.org>,
	Leilk Liu <leilk.liu@...iatek.com>,
	Matthias Brugger <matthias.bgg@...il.com>,
	linux-spi@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
	linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH] spi: mediatek: single device does not require cs_gpios

On Thu, Nov 5, 2015 at 5:16 PM, Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
> On Thu, Nov 5, 2015 at 7:50 AM, Nicolas Boichat <drinkcat@...omium.org> wrote:
[...]
>> diff --git a/drivers/spi/spi-mt65xx.c b/drivers/spi/spi-mt65xx.c
>> index 563954a..f694031 100644
>> --- a/drivers/spi/spi-mt65xx.c
>> +++ b/drivers/spi/spi-mt65xx.c
>> @@ -410,7 +410,7 @@ static int mtk_spi_setup(struct spi_device *spi)
>>         if (!spi->controller_data)
>>                 spi->controller_data = (void *)&mtk_default_chip_info;
>>
>> -       if (mdata->dev_comp->need_pad_sel)
>> +       if (mdata->dev_comp->need_pad_sel && spi->cs_gpio >= 0)
>
> gpio_is_valid() ?

Yes, thanks! Will fix in next round. (there is a few other ones in
driver/spi/* that should probably be fixed too...)

Best,
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/