[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20151105030221.68b7e98c.akpm@linux-foundation.org>
Date: Thu, 5 Nov 2015 03:02:21 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: Thierry Reding <thierry.reding@...il.com>
Cc: Arnd Bergmann <arnd@...db.de>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Joe Perches <joe@...ches.com>, linux-arch@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] asm/sections: Add helpers to check for section data
On Thu, 29 Oct 2015 09:26:06 +0100 Thierry Reding <thierry.reding@...il.com> wrote:
> From: Thierry Reding <treding@...dia.com>
>
> Add a helper to check if an object (given an address and a size) is part
> of a section (given beginning and end addresses). For convenience, also
> provide a helper that performs this check for __init data using the
> __init_begin and __init_end limits.
>
> ...
>
> --- a/include/asm-generic/sections.h
> +++ b/include/asm-generic/sections.h
> @@ -63,4 +63,15 @@ static inline int arch_is_kernel_data(unsigned long addr)
> }
> #endif
>
> +static inline bool section_contains(void *virt, size_t size, void *begin,
> + void *end)
> +{
> + return virt >= begin && virt + size <= end;
> +}
This is ambiguous: does it return true if the object is wholly within
the region, or if it is only partially within the region. A code
comment will help. Something like
/*
* Return true if the region described by [virt, virt+size) is wholly contained
* within the region described by [begin, end).
*/
Which makes me wonder whether this function should in fact do
"partially within". Shrug, doesn't matter much I guess.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists